Deprecate tag rename (PUT /v2/tags/:name) #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should remove import for "errors" in https://github.com/digitalocean/doctl/blob/81e643563091da0cd0199e18c6213b3df76bfc9e/commands/tags_test.go#L17
It's not needed anymore and causes tests to fail.
Other than that LGTM 👍
cc @mchitten @mauricio
|
mchitten
force-pushed
the
deprecate/tag-rename
branch
from
81e6435 to
a376a75
Compare
|
Awesome! Thanks Mike! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our changelog, tag rename will be deprecated on April 26, 2017.
cc @mauricio @hugocorbucci @magicgrl111